Conversation
Member
|
Can nucleus/cluster/windows/Native/DcomConfigurator be removed? Also, don't forget the documentation |
kalinchan
requested changes
Feb 3, 2026
Member
There was a problem hiding this comment.
References still exist in the following places:
- nucleus/cluster/admin-l10n/src/main/resources/com/sun/enterprise/v3/admin/cluster/*.properties
- nucleus/cluster/cli/src/main/java/com/sun/enterprise/admin/cli/cluster/LocalStrings.properties
- nucleus/cluster/cli-l10n/src/main/resources/com/sun/enterprise/admin/cli/cluster/*.properties
- appserver/admingui/cluster/src/main/resources/node/nodeEdit.jsf
- appserver/admingui/cluster/src/main/resources/node/nodeAttr.inc
- appserver/admingui/cluster/src/main/resources/node/nodeJS.inc
- appserver/admingui/cluster/src/main/resources/node/nodeNew.jsf
- appserver/admingui/cluster/src/main/resources/node/nodes.jsf
- appserver/admingui/cluster/src/main/resources/node/nodesButtons.inc
- appserver/admingui/cluster/src/main/resources/org/glassfish/cluster/admingui/Strings.properties
- appserver/admingui/cluster-l10n/src/main/resources/org/glassfish/cluster/admingui/*.properties
- appserver/admingui/reference-manual/src/main/help/en/help/reference/*.html
- nucleus/cluster/admin-l10n/src/main/resources/com/sun/enterprise/v3/admin/cluster/*.properties
The following can be deleted:
- nucleus/cluster/admin-l10n/src/main/resources/com/sun/enterprise/v3/admin/cluster/dcom
- appserver/admingui/reference-manual/src/main/help/en/help/reference/create-node-dcom.html
Various references to dcom are still present and potentially out of scope, but jinterop may be able to be removed.
You may be able to use javaee/glassfish#22343 as a reference,
Contributor
|
@Viii3 please review last comment from @kalinchan some properties files are referencing DCOM |
Includes obvious cases where DOCM is in the key. Does not include cases where DCOM is part of a sentence in non-English translations.
Contributor
|
@Viii3 There are some conflicts to solve, please review |
# Conflicts: # appserver/admingui/reference-manual/src/main/help/en/help/reference/create-local-instance.html # appserver/admingui/reference-manual/src/main/help/en/help/reference/delete-local-instance.html # appserver/admingui/reference-manual/src/main/help/en/help/reference/toc.html
kalinchan
requested changes
Feb 6, 2026
Member
kalinchan
left a comment
kalinchan
left a comment
There was a problem hiding this comment.
References still exist in various places
kalinchan
requested changes
Feb 6, 2026
Member
kalinchan
left a comment
kalinchan
left a comment
There was a problem hiding this comment.
References exist:
- appserver/admingui/cluster-l10n/src/main/resources/org/glassfish/cluster/admingui/*.properties
- nucleus/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/Node.java
- appserver/admingui/reference-manual/src/main/help/en/help/toc.xml
Remaining references to jinterop can be removed as well
Viii3
force-pushed
the
FISH-8651-Remove-DCOM
branch
from
e0cf0ff to
1d5bc30
Compare
kalinchan
requested changes
Feb 9, 2026
Member
kalinchan
left a comment
kalinchan
left a comment
There was a problem hiding this comment.
Exception occurs when trying to create a new node within the admin console:
[#|2026-02-09T09:36:14.501+0000|SEVERE|Payara 7.2026.2|jakarta.enterprise.resource.webcontainer.faces.context|_ThreadID=222;_ThreadName=admin-thread-pool::admin-listener(3);_TimeMillis=1770629774501;_LevelValue=1000;|
java.lang.RuntimeException: java.lang.reflect.InvocationTargetException while attempting to process a 'beforeCreate' event for 'event181'.
java.lang.RuntimeException: java.lang.reflect.InvocationTargetException while attempting to process a 'beforeCreate' event for 'event181'.
...
Caused by: com.sun.jsftemplating.handlers.HandlerException: #{requestScope.vMap} resolved to null
at com.sun.jsftemplating.handlers.UtilHandlers.mapPut(UtilHandlers.java:286)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
... 49 more
|#]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Important Info
Blockers
Testing
New tests
Testing Performed
Testing Environment
Maven version: 3.9.6
Java version: 21.0.3, vendor: Eclipse Adoptium
Default locale: en_GB, platform encoding: UTF-8
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"
Documentation
Notes for Reviewers